Skip to content

Commit

Permalink
Merge pull request #789 from wangvsa/dev
Browse files Browse the repository at this point in the history
Do not assume file must exist after an open call
  • Loading branch information
adammoody authored Jul 31, 2023
2 parents ced87e7 + d23aafe commit 537301c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions client/src/unifyfs_fid.c
Original file line number Diff line number Diff line change
Expand Up @@ -553,15 +553,15 @@ int unifyfs_fid_open(
}
}

/* File should exist at this point,
* update our cache with its metadata. */
/* Update our cache with its metadata. */
ret = unifyfs_fid_fetch(client, path);
if (ret != UNIFYFS_SUCCESS) {
/* Failed to get metadata for a file that should exist.
* Perhaps it was since deleted. We could try to create
* it again and loop through these steps, but for now
* consider this situation to be an error. */
LOGERR("Failed to get metadata on existing file %s", path);
/* Failed to get metadata.
* Perhaps it was opened without O_CREAT or it
* was since deleted. For the latter, we could
* try to create it again and loop through these
* steps. */
LOGDBG("Failed to get metadata on file %s", path);
return ret;
}

Expand Down

0 comments on commit 537301c

Please sign in to comment.