Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for logio header that doesn't fit in one page due to chunk size #635

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

MichaelBrim
Copy link
Collaborator

Description

Avoids unexpected unifyfs_mount() failures for clients that customize UNIFYFS_LOGIO_CHUNK_SIZE.

Motivation and Context

The current logio header uses a single page to hold its metadata, which includes the chunk slotmap. For large shmem or spill regions with small chunk sizes, it is possible that a page is not large enough to hold the whole slotmap, which causes client applications to fail during unifyfs_mount().

This PR allows for the logio header to grow to as many pages as necessary to hold the chunk slotmap for the given region and chunk size.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@CamStan
Copy link
Member

CamStan commented Jun 4, 2021

Yay, more CI problems. 😫
I rebuilt the dev branch in my fork, and Travis is failing there as well. So your changes aren't causing anything.

At first glance the only difference I could see between previous successful builds was the Mercury version had changed, but changing that still fails for the same reason.

So I starting thinking something changed with Spack.
Wondering if this is causing the problem spack/spack#24020

Copy link
Member

@CamStan CamStan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue in Spack got resolved and fixed our Travis builds.

@adammoody adammoody merged commit 2a0352a into LLNL:dev Jun 7, 2021
@adammoody
Copy link
Collaborator

Thanks @MichaelBrim and @CamStan

@MichaelBrim MichaelBrim deleted the logio-slotmap branch June 8, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants