Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PMIX_JOB_SIZE instead of PMIX_UNIV_SIZE #712

Merged
merged 1 commit into from
May 16, 2022

Conversation

rgmiller
Copy link
Contributor

The PMIX_UNIV_SIZE value is the number of allocated slots in the job
whereas the PMIX_JOB_SIZE is the number of actual processes that have
been started. When trying to calculate how many instances of unifyfsd
to expect, PMIX_JOB_SIZE is the correct value.

See issue #707

Description

This changes the PMIx init code to use PMIX_JOB_SIZE instead of PMIX_UNIV_SIZE. It also replaces strncpy() with strlcpy() in a few places.

Motivation and Context

See #707

How Has This Been Tested?

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [ x] All commit messages are properly formatted.

The PMIX_UNIV_SIZE value is the number of allocated slots in the job
whereas the PMIX_JOB_SIZE is the number of actual processes that have
been started.  When trying to calculate how many instances of unifyfsd
to expect, PMIX_JOB_SIZE is the correct value.

See issue LLNL#707
@adammoody adammoody merged commit f31753f into LLNL:dev May 16, 2022
@CamStan CamStan mentioned this pull request May 16, 2022
@rgmiller rgmiller deleted the pmix_univ_size_bug branch May 20, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants