Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid request signal if RM thread exiting #721

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

MichaelBrim
Copy link
Collaborator

Description

Potential fix by avoid pthread condition operations for request manager threads that are in the process of being shut down.

Motivation and Context

See issue #691

How Has This Been Tested?

Tested in Ubuntu docker.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@CamStan
Copy link
Member

CamStan commented Jul 25, 2022

Tested this branch. Looks like this will resolve #691.

@MichaelBrim MichaelBrim marked this pull request as ready for review August 1, 2022 19:09
@adammoody adammoody merged commit a0ce7c6 into LLNL:dev Aug 1, 2022
@MichaelBrim MichaelBrim deleted the issue-691 branch October 6, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants