Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortram mpi wrappers have wrong parameter types #795

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

wangvsa
Copy link
Collaborator

@wangvsa wangvsa commented Aug 31, 2023

Description

There's a strange error when running a FLASH5 simulation on Summit:

*** The MPI_Init_thread() function was called before MPI_INIT was invoked.
*** This is disallowed by the MPI standard.
*** Your MPI job will now abort.

The actual issue is not calling MPI_Init_thread before MPI_Init, but caused by the invalid required parameter value.
(strange how this irrelevant error message showed up).

Fix

The previous MPI_Init_thread wrapper has a wrong parameter type for required. Instead of int required, it should be MPI_Fint* required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Signed-off-by: Chen Wang <wangvsa@gmail.com>
Copy link
Collaborator

@MichaelBrim MichaelBrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chen, you beat me to the PR. I had the same fix in one of my branches for Seung-Hwan.

@adammoody adammoody merged commit cc63788 into LLNL:dev Sep 1, 2023
6 checks passed
@adammoody
Copy link
Collaborator

Thanks @wangvsa and @MichaelBrim !

@wangvsa wangvsa deleted the fortran-mpi-wrapper branch September 11, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants