Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ray Bezier/NURBS surface intersection routines #1477
base: develop
Are you sure you want to change the base?
Adds ray Bezier/NURBS surface intersection routines #1477
Changes from 40 commits
59998fd
c5e50aa
a1311fd
99ea55a
38c2c1b
b40a8b6
2bcf272
45a73b4
cab1cc8
77c3c55
11542e1
d65be3f
031cb48
198e9b0
2637d7e
de88b02
0106a24
77d0b64
8a479eb
02026f0
43d4514
488b8fb
aed9364
7338840
9e7d5d9
b38472f
19288ac
c13e497
d62231a
3ebe85d
d731175
bb1a9b6
47a865c
b2bcd64
26ece15
3dda94b
543a609
d9cb8d5
fc7e752
ccded5e
d200978
3ea874e
4bac344
7161682
3392880
8499306
989844d
5758e7a
7909120
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Is normalization required for the intended use of
Line
? Are there cases where we might not want to normalize the direction vector?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily, but the
primal::Ray
class does too, and I can come up with a couple reasons why it could be useful. For example, the magntude doesn't have a useful meaning inherently, and making it a unit vector makes the math objects have a consistent parameterization, which is more useful in algortihms.