Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System externals cleanup #563

Closed
pearce8 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #649
Closed

System externals cleanup #563

pearce8 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #649
Assignees
@michaelmckinsey1
Labels
feature New feature or request

Comments

@pearce8
Copy link
Collaborator

pearce8 commented Jan 24, 2025

System externals should be sorted

Is there a utility to sort the yaml files alphabetically? Could we have a function to fix up a yaml file?

System externals can currently be stored in a yaml format, and also as a string in system.py.

These will be merged at system instantiation, but it is difficult for a human to know what this defines, and if there is more than one definition for a library, it is unclear which one would be used. Any suggestions?
@pearce8 pearce8 added the feature New feature or request label Jan 24, 2025
@michaelmckinsey1 michaelmckinsey1 mentioned this issue Feb 28, 2025
Draft
13 tasks
@michaelmckinsey1 michaelmckinsey1 linked a pull request Feb 28, 2025 that will close this issue
[WIP] Apply yamlfmt to yaml files #649
Draft
13 tasks
@pearce8
Copy link
Collaborator Author

pearce8 commented Mar 7, 2025

Superseded by #658.

@pearce8 pearce8 closed this as completed Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Apply yamlfmt to yaml files LLNL/benchpark
3 participants
@scheibelp @pearce8 @michaelmckinsey1