-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Systems to Initialize Using Dictionaries #658
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want these refactored into the system.py
, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. @becker33, what do you think?
I've noticed how this is currently done in develop, some files have headers and some do not: Case 1
Case 2
Case 3No headers
Shouldn't this be consistent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelmckinsey1 I added more tasks in this PR. Take a look and let me know what is already tackled - vs. needs to be added.
2a5bf2f
to
d61d95d
Compare
|
ad9407e
to
e6a1ffa
Compare
06fe351
to
5f2eafc
Compare
6f00331
to
6a7b083
Compare
Refactor the way systems are initialized to be similar to how experiments are initialized, using dictionaries instead of multi-line strings and yaml files.
yaml.dump
will do this.system.py
's which have yaml files storedFor packages stored as a string right now, move the string to a file first?Packages stored as strings converted to dictionaries in-place.Adding/modifying a system (docs: Adding a System)
Done (Migrate information in yamls
systems/x/*.yaml
tosystem.py
)Adding/modifying core functionality, CI, or documentation:
lib/benchpark/system/py
andlib/benchpark/cmd/system.py