Remove block of BLT check logic (redundant with block below) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure check for whether BLT is loaded is in the right spot when camp is a submodule in a project that is a submodule of another project.
davidbeckingsale
approved these changes
Feb 24, 2022
|
Huh, I wonder how that happened. Works for me. If the other tweak works for you @davidbeckingsale I'll get these two in and re-tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure check for whether BLT is loaded is in the right spot
when camp is a submodule in a project that is a submodule of another project.
Note: that the removed code is not wrong, technically. However, what is in this PR is consistent with our other projects that use BLT.