Avoid naming array in CAMP_EXPAND #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass directly to sink, do not give a name
trws
approved these changes
Oct 6, 2022
|
I cannot wait to be able to make this macro use C++17, thanks again @MrBurmark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid naming array in CAMP_EXPAND so it is more compatible with existing code. This should avoid causing errors is EXPAND is used multiple times in the same scope.
@mcfadden8 found that the previous change broke umpire as umpire passed the result to a sink like function to quiet the warning. This change will still break umpire as sink returns void, but its fixed here LLNL/Umpire#786 (review).