Removing duplicated properties in recursive list. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are experiencing the same problem in Spack: the length of runtime_includes is 60896989 (seen from gdb). The build time is too long (> 7 hours not completing). We will try your solution to this problem and feedback if it works. UPDATE: it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
get_recursive_listfunction inelec/CMakeLists.txtmay produce a list with lots of duplicate items, which may be even longer when building the project with Spack. This can lead to a significant reduction of building speed. Due to this problem, we can't build the package in a reasonable time on our cluster.In this patch, we try to remove these duplicate items in list before setting the return value. This will make cmake stage much faster.