Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting tree by hatchet_nid, and tests #108

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

dyokelson
Copy link
Collaborator

@dyokelson dyokelson commented Sep 9, 2023

The tree printout was sorting alphabetically so it looked different than the dataframe which sorts by _hatchet_nid. Now the tree sorts roots and children by the _hatchet_nid and matches the dataframe.

@dyokelson dyokelson requested a review from slabasan September 9, 2023 00:13
@dyokelson dyokelson self-assigned this Sep 9, 2023
@dyokelson dyokelson added bug priority-urgent Urgent priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs area-visualization Issues and PRs involving any of the Hatchet provided visualizations labels Sep 9, 2023
@slabasan slabasan removed the bug label Sep 19, 2023
black formatting for test file

fixing node ordering during squash

black reformat
@dyokelson dyokelson force-pushed the tree-ordering-bug-fix branch from 294389e to 91cd378 Compare September 20, 2023 19:26
@slabasan slabasan merged commit dea97ca into LLNL:develop Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-visualization Issues and PRs involving any of the Hatchet provided visualizations priority-urgent Urgent priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants