Change "nid" Casted Value in caliper_native_reader to np.int64 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
force-pushed
the
fix-nid_cast
branch
from
68466c9 to
e527489
Compare
michaelmckinsey1
added
area-readers
slabasan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working with
GraphFrame.to_hdf()I noticed that thepytablesbackend does not support the current datatype of thenidcolumn, causing:Most datatypes in Pandas columns get casted to Numpy datatypes . We needed to use
pd.Int64Dtype()for time series data sincenp.int64does not support NaN values. By casting the "nid" column tonp.float64instead ofpd.Int64Dtype(), the issue is fixed withpytablesand we can support NaN values for time series.