-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dense matrix needs RAJA when GPU is used #676
Conversation
I didn't have enough time to got though why incline is failing and to fix the issue, but I am quite confused. I had done some initial debugging to add more print statements and to work around the obvious errors, but I couldn't even push to the repo anymore...
I gave up getting ROCm 4.5.1 working again, and tried 5.3.0. 4.5.1 seemed unfixable, and then 5.3.0 seems more promising. ROCm 5.6.0+ and ROCm 6+ are both available now, so perhaps it would just be easiest to re-vamp HiOp CI a little to be more like Re::Solve that builds it's own ROCm/HIP and clang from source. cc @jaelynlitz if you have any idea what changed on incline recently @nychiang or @cnpetra I think I might need to be re-added to the repo in order to push again? https://github.com/ORNL/ReSolve/blob/develop/buildsystem/spack/incline/spack.yaml - here is the ReSolve YAML for comparison / as a reference |
I have a couple thoughts:
|
@cameronrutherford I just checked it and you always have the read access to the hiop repos (same as @jaelynlitz). Not sure what the problem is. |
@nychiang the error is misleading, and my language is intending to clarify - I can read all day long, but I cannot push changes |
I worked through some of these issues myself but unable to push changes. There are some small fixes to work through some of these issues, but clearly incline changed enough to have broken the builds completely with the old compiler. I maintain my position that we just need to build a la Re::Solve and have the compiler / ROCm be built from source by spack to avoid these issues. @jaelynlitz lets disable exasgd account on HPC sooner rather than later :) |
77efbfc
to
2400342
Compare
I would prefer to have an error message when GPU is on but raja is off. |
@cameronrutherford I think now you can push to the repository. I added an error message if GPU is ON and RAJA is off. We'd like to merge this one first, and release v1.0.3. Would you mind filing your changes in another PR? |
@cnpetra Please release v1.0.3 after merging this PR. I will try to create update the Spack formula. |
I made #680 to track Incline CI fixing and other associated issues that could be fixed by a CI re-vamp. This can be merged from my perspective, and Spack PR was merged this morning. |
Update the cmake file and add an assertion, to prevent compiling hiop with GPU support but without RAJA.
CLOSE #675