Skip to content

Commit

Permalink
Explictly wrap queue name string in quotes to make it more robust (#320)
Browse files Browse the repository at this point in the history
* Explictly wrap queue name string in quotes to make it more robust

* Move CHANGELOG note to v1.8.0
  • Loading branch information
lucpeterson authored Jul 1, 2021
1 parent b798b08 commit 10e8b53
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ All notable changes to Merlin will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


## [1.8.0]

### Added
Expand All @@ -30,6 +31,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Flake8 examination slightly modified for more generous cyclomatic complexity.
- Certain tests and source code have been refactored to abide by Flake8 conventions.

### Fixed
- Explictly wrap queue string in quotes for robustness

## [1.7.9]

### Fixed
Expand Down
3 changes: 2 additions & 1 deletion merlin/spec/specification.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,8 @@ def make_queue_string(self, steps):
param steps: a list of step names
"""
return ",".join(set(self.get_queue_list(steps)))
queues = ",".join(set(self.get_queue_list(steps)))
return f"\"{queues}\""

def get_worker_names(self):
result = []
Expand Down

0 comments on commit 10e8b53

Please sign in to comment.