Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery Manager #489

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

Celery Manager #489

wants to merge 32 commits into from

Conversation

ryannova
Copy link
Member

@ryannova ryannova commented Aug 7, 2024

Create a celery manager that automatically manages the celery workers and restarts them accordingly when they have become unresponsive.

merlin manager command was added and there are 3 options run start and stop.

  • run: starts the manager but is processing blocking but allows users to see the manager outputs and will be the main function for replacing merlin monitor for allocation management.
  • start: starts the manager in a background process and is non-blocking.
  • stop: stops the manager from a background or run process.

@ryannova ryannova added the enhancement New feature or request label Aug 7, 2024
@ryannova ryannova self-assigned this Aug 7, 2024
merlin/main.py Show resolved Hide resolved
merlin/main.py Outdated Show resolved Hide resolved
merlin/main.py Outdated Show resolved Hide resolved
merlin/study/celerymanager.py Outdated Show resolved Hide resolved
merlin/study/celerymanager.py Outdated Show resolved Hide resolved
merlin/study/celerymanageradapter.py Outdated Show resolved Hide resolved
merlin/study/celerymanager.py Outdated Show resolved Hide resolved
merlin/study/celerymanageradapter.py Outdated Show resolved Hide resolved
@lucpeterson
Copy link
Member

Ping on this. Is the plan to merge the new test stuff in and then keep going?

@bgunnar5
Copy link
Member

@lucpeterson yeah that's the plan. Once the new tests are merged then all these tests should pass. We'll still need to create tests for the manager itself but I'm going to get started on that hopefully this week. We also need to figure out a good way to integrate the manager command with the existing monitor command, as there's a lot of overlap there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants