Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version defined in two different places, but not in the msr_safe.h struct msr_batch_array #167

Closed
rountree opened this issue Sep 13, 2024 · 0 comments · Fixed by #168
Closed

Version defined in two different places, but not in the msr_safe.h struct msr_batch_array #167

rountree opened this issue Sep 13, 2024 · 0 comments · Fixed by #168

Comments

@rountree
Copy link
Collaborator

The makefile has a CURRENT_VERSION variable (set to "1.7.0") for use in msrsave.

The MODULE_VERSION in msr-entry.c is set to "1.7".

There's nothing in struct msr_batch_array that would hold the version the user thinks they're compiling against.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Single source of truth for version information. rountree/msr-safe
1 participant
@rountree