Single source of truth for version information. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msr_version.h #defines for major, minor, and patch versions of msr-safe as well as helper macros to generate _u32 and string representation. Makefile Removes CURRENT_VERSION and -DVERSION from build. msrsave now gets the version string from msr_version.h msrsave_main.c msr_entry.c Now #includes msr_version.h and uses MSR_SAFE_VERSION_STR msr_safe.h Repurposes a bit of struct padding to hold a _u32-format msr-safe version number. README.md Updates documentation of struct msr_batch_array to note the new version field. Explains how this will remain unused in the 1.x.y series. Version 2.x.y will begin checking this version field to make sure what the user compiled against is the same version as the loaded kernel module. This is necessary due to anticipated batch API changes in version 2.0.0. Tested on serif (Ubuntu 24.04.1 LTS, Linux 6.8.0, gcc 13.2.0)
slabasan
reviewed
Sep 17, 2024
msr_entry.c
Outdated
| @@ -396,5 +396,5 @@ module_exit(msr_exit) | |||
|
|
|||
| MODULE_AUTHOR("M. Fadden, K. Shoga, B. Rountree, H. P. Anvin"); | |||
| MODULE_DESCRIPTION("x86 generic MSR driver (+LLNL Approved List)"); | |||
| MODULE_VERSION("1.7"); | |||
| MODULE_VERSION( MSR_SAFE_VERSION_STR ); | |||
slabasan
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
msr_version.h
#defines for major, minor, and patch versions of msr-safe
as well as helper macros to generate _u32 and string
representation.
Makefile
Removes CURRENT_VERSION and -DVERSION from build.
msrsave now gets the version string from msr_version.h
msrsave_main.c
msr_entry.c
Now #includes msr_version.h and uses MSR_SAFE_VERSION_STR
msr_safe.h
Repurposes a bit of struct padding to hold a _u32-format
msr-safe version number.
README.md
Updates documentation of struct msr_batch_array to note
the new version field. Explains how this will remain
unused in the 1.x.y series. Version 2.x.y will begin
checking this version field to make sure what the user
compiled against is the same version as the loaded
kernel module. This is necessary due to anticipated
batch API changes in version 2.0.0.
Tested on serif (Ubuntu 24.04.1 LTS, Linux 6.8.0, gcc 13.2.0)