Toss4 cleanup #166
Merged
Toss4 cleanup #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of (((struct class *)0)->devnode) has changed at least twice in the mainline kernel. Coding based on mainline kernel versions has repeatedly run into the problem of distros backporting features to older kernels. Solved here using _Generic and multiple function definitions.
slabasan
reviewed
Sep 17, 2024
slabasan
reviewed
Sep 17, 2024
msr_batch.c
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2011-2021 Lawrence Livermore National Security, LLC and other | |||
| // Copyright 2012-2021 Lawrence Livermore National Security, LLC and other | |||
There was a problem hiding this comment.
Start copyright year at 2011
There was a problem hiding this comment.
I'm not sure if this file existed in 2011. Github history doesn't go back that far and.... never mind. 2011 it is.
slabasan
reviewed
Sep 17, 2024
msr_allowlist.c
Outdated
| #endif | ||
|
|
||
| #define msr_allowlist_nodename_selector _Generic(\ | ||
| (((struct class *)0)->devnode),\ |
There was a problem hiding this comment.
Use 4 spaces instead of 8 for indent
slabasan
reviewed
Sep 17, 2024
msr_batch.c
Outdated
| #endif | ||
| #endif | ||
| #define msrbatch_nodename_selector _Generic(\ | ||
| (((struct class *)0)->devnode),\ |
There was a problem hiding this comment.
Use 4 spaces instead of 8 for indent
Per Stephanie's comments.
- add new lines between function definitions - use 4 instead of 8 spaces for indents
slabasan
force-pushed
the
toss4-cleanup
branch
from
ffd7036 to
fcc68be
Compare
slabasan
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #define around msr_devnode with _Generic.
The type of (((struct class *)0)->devnode) has changed at least
twice in the mainline kernel. Coding based on mainline kernel
versions has repeatedly run into the problem of distros backporting
features to older kernels.
Solved here using _Generic and multiple function definitions.