test tweaking github-py to >=2.0.0 for python 3.9 support #60
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
update/python-support
branch
from
66342c7
to
eda31b2
Compare
|
@IanLee1521 not sure why tests aren't running here (perhaps GH-actions are disabled) but I opened a PR to my branch to show working: https://github.com/researchapps/scraper/actions/runs/2472598848. I also ran the version here against the (currently broken but with the patch here fixed!) contributor-ci action: https://github.com/vsoch/contributor-ci/runs/6824670095?check_suite_focus=true. Works! So I think it would be great to have a release soon, and of course let me know if you want more work here. |
|
thank you! |
|
@IanLee1521 what is the schedule / protocol for new releases? |
|
Basically just when I feel like it. I was trying to test installing in a pipenv, and having trouble, but as soon as I confirm a couple simple cases, I can push out the release. |
|
okay sounds good! Can you post here when you do? And no rush, I put in a custom branch fix a few weeks ago, so I can update this in my tooling whenever is good for you. |
|
@vsoch - Sorry for the delay! This is now uploaded to: https://pypi.org/project/llnl-scraper/0.11.0/ Hopefully we didn't break anything along the way 🙃 |
|
Thank you!! |
An import of Callable from collections (instead of collections.abc) in the pinned version means that it breaks with newer Python. Thus we should try to support github3 >= 2.0.0 when this was fixed. This is a test PR to see how dire this change is I am anticipating it will break for older Python versions in which case we should have a discussion about how to properly address this!) It could just be that we move forward supporting newer Python versions and add a note to the README for older versions to use an older version of the library.
I'm not sure why tests aren't triggering but I'm guessing it's because either I need approval (somewhere I can't see that is not here) or .travis.ci is since disconnected because it sort of has died in the last few years. Let me know if you'd like a new testing setup I'd be happy to do that. :)
This will fix #59
Signed-off-by: vsoch vsoch@users.noreply.github.com