Improve process output handling and streamline cloc JSON parsing
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already redirect stderr to stdout ine the Popen() call we do not need the output of stderr from communicate() method. Additionally we explicitly decode the bytes returned from the communicate() method as a UTF-8 string. Using str() to type coerce the value results in a bytes string literal instead of an appropriate UTF-8 str value.
Now that the returned value of the execute() function is a UTF-8 string we do not need to perform any pre-processing before we use the json.loads() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how the
scraper.util.execute()function handles process output. With this improved output handling we can also streamline processing the JSON output of thecloccommand in thescraper.util.git_repo_to_sloc()function.