Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVODE example guide (currently without Deep Dive) #377

Draft
wants to merge 35 commits into
base: develop
Choose a base branch
from

Conversation

drreynolds
Copy link
Collaborator

This is a cleaned up PR for #309, that only includes changes inside the doc folder.

johnwparent and others added 30 commits September 12, 2023 20:23
example_utilities.hpp requires `stoi` and similar methods. These are
declared in `<string>`, but `<string>` is not included. This means this
file will break any TU it's included in.

Resolves #330

Co-authored-by: Cody Balos <balos1@llnl.gov>
Fixes #335

Co-authored-by: David Gardner <gardner48@llnl.gov>
Fixes #333. Some other typedefs already had specialized (towards idas or
cvodes) prefixed names, it won't harm to generalize this.

---------

Co-authored-by: Cody Balos <balos1@llnl.gov>
Add scripts for comparing benchmark and example timings against release timings and a notebook using Thicket to visualize data

---------

Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Co-authored-by: Cody J. Balos <balos1@llnl.gov>
Fixes part of #253 by avoiding nested loops that take `O(M*N)` operations.

Also fixes #256.

---------

Signed-off-by: phannebohm <phannebohm@fh-bielefeld.de>
Co-authored-by: Cody Balos <balos1@llnl.gov>
Fix missing soversion on some SUNLinSol and SUNNonlinSol targets

---------

Signed-off-by: Julien Schueller <schueller@phimeca.com>
Co-authored-by: Cody Balos <balos1@llnl.gov>
1. Adds missing implicit tables to the ARKODE constants docs
2. Makes formatting of constants consistent in ARKODE docs
3. Groups implicit tables by order

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Update ARKStepSetTableNum to recognize ARK2-3-1-2 as a valid ARK pair.
Fixes #339: A regression was introduced by the stop time bug fix in
v6.6.1 causing integrators to return at the stop time rather than the
requested output time if the stop time was reached in the same step in
which the output time was passed.

Also fixes a missing check in ARKODE to interpolate (or not) the
solution at the stop time.
Fix CVodeQuadSStolerances docs, add CVodeQuadSVtolerances docs (Fixes #340)
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the
defaults like #345

---------

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: David Gardner <gardner48@llnl.gov>
This PR adds the ginkgo dpcpp support in the examples: sunmatrix,
sunlinsol, and cvode/cv_heat2D

I currently only know `queue->wait_and_throw()` to synchronize which
requires queue unlike `cudaDeviceSynchronize` or `hipDeviceSynchronize`
In sunlinsol and cv_heat2D, some function signatures are also used in
other files such that I can not pass an additional parameter.
I use global variable to store ginkgo executor and then get the queue
when SYCL needs sync or submit the kernel in those functions.

---------

Signed-off-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
Co-authored-by: Cody Balos <balos1@llnl.gov>
Always append hipblas and hipsparse CMake targets with HIP backend as these
libraries are not reliably included in the pkgconfig file.

Replace cublas and cusparse with the CMake targets because the library path in
the pkgconfig file is not reliable. Specifically, the path is wrong on systems
using the NVIDIA HPC SDK.

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Added Fortran support for the LAPACK dense SUNLinearSolver implementation.

---------

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
 Additional embedded explicit Runge--Kutta
methods to ARKODE.

---------

Co-authored-by: Steven Roberts <roberts115@llnl.gov>
Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Updated `SUNProfiler` to note rely on `MPI_WTime`. Fixes #312 

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Fix the description of `ONE_STEP` mode in ARKODE. The solution at the
end of the step is always returned and interpolation is not performed.
Upload artifact with just output files so the artifact is smaller

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Remove unused files from the repo
* Cancel existing workflow on new push
* Add dispatch trigger for all actions
* Upload all outputs from testing directory

---------

Co-authored-by: Cody Balos <cjbalos@gmail.com>
Remove F77 interface examples from `develop` branch. Once this PR is
merged, a new `archive` branch can be created for easy reference until
#302 is merged and the `archive` branch can be deleted.

---------

Co-authored-by: Cody Balos <balos1@llnl.gov>
Simplify tarscript to include directories rather than individual files

---------

Co-authored-by: Cody Balos <balos1@llnl.gov>
Fixed a bug in ERKStep where methods with `c[s-1] = 1` but `a[s-1,j] !=
b[j]` were incorrectly treated as having the first same as last (FSAL)
property.

Fixed a bug in `MRIStepCoupling_Write` where explicit coupling tables
were not written to the output file pointer.

ARKStep, ERKStep, MRIStep, and SPRKStep were updated to remove a
potentially unnecessary right-hand side evaluation at the end of an
integration. ARKStep was additionally updated to remove extra right-hand
side evaluations when using an explicit method or an implicit method
with an explicit first stage.

The `MRIStepInnerStepper` class in MRIStep was updated to make supplying
an `MRIStepInnerFullRhsFn` optional.

---------

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Cody Balos <balos1@llnl.gov>
New object-oriented infrastructure for time step adaptivity controllers.

---------

Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Co-authored-by: Balos, Cody, J <balos1@llnl.gov>
Co-authored-by: Cody Balos <cjbalos@gmail.com>
Add developer docs to RTD superbuild
Add instructions for updating answers in the developer docs.

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Remove deprecated functions

---------

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Remove `realtype`, `booleantype`, and related deprecated macros.

---------

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
Co-authored-by: David J. Gardner <gardner48@llnl.gov>
Fix table name for the implicit part of 5th order IMEX-ARK methods
@balos1 balos1 added this to the SUNDIALS 7.0.0 milestone Nov 27, 2023
@balos1 balos1 removed this from the SUNDIALS 7.0.0 milestone Dec 6, 2023
@gardner48 gardner48 marked this pull request as draft June 21, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.