Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SYCL vector for oneapi 2025 #617

Merged
merged 23 commits into from
Dec 10, 2024
Merged

Fix SYCL vector for oneapi 2025 #617

merged 23 commits into from
Dec 10, 2024

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Dec 10, 2024 •
edited
Loading

Fix for #596

@balos1 balos1 changed the title Bugfix/sycl vec 202500 [WIP] Fix SYCL vector for oneapi 2025 Dec 10, 2024
@balos1 balos1 changed the title [WIP] Fix SYCL vector for oneapi 2025 Fix SYCL vector for oneapi 2025 Dec 10, 2024
@balos1 balos1 marked this pull request as ready for review December 10, 2024 09:31
@gardner48 gardner48 added this to the SUNDIALS Next milestone Dec 10, 2024
gardner48
gardner48 requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to note the SYCL fix in the change log

@balos1 balos1 mentioned this pull request Dec 10, 2024
Open
@balos1 balos1 requested a review from gardner48 December 10, 2024 21:27
@gardner48 gardner48 merged commit 175fe69 into develop Dec 10, 2024
30 of 31 checks passed
@gardner48 gardner48 deleted the bugfix/sycl-vec-202500 branch December 10, 2024 23:30
@balos1 balos1 mentioned this pull request Dec 11, 2024
Closed
@baperry2 baperry2 mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steven-Roberts Steven-Roberts Steven-Roberts left review comments

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

@drreynolds drreynolds Awaiting requested review from drreynolds drreynolds is a code owner

@gardner48 gardner48 Awaiting requested review from gardner48 gardner48 is a code owner

Assignees
No one assigned
Labels
bug ci sycl-dpcpp
Projects
None yet
Milestone
SUNDIALS 7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@balos1 @Steven-Roberts @gardner48