Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mirror configurable in spack_config #37

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

adrienbernede
Copy link
Member

Addresses #32

This is a basic proposal to address the issue.
However it is not protected against some cases, like if someone configures a mirror in the json file, and then another on command line.

@white238
Copy link
Member

white238 commented Dec 4, 2020

Unless I'm missing something, having the mirror.yaml not under the SYS_TYPE folder seems like it wouldn't work. For example, if I put /usr/workspace/some_shared_space/mirror like we normally do for LC, what happens on your personal machine? Does Spack have logic in there to toggle based on environment variables? You can in environment files but reading their documentation isn't helping me find it in the mirrors.yaml.

@cyrush
Copy link
Member

cyrush commented Dec 4, 2020

@white238 in the wonderful universe of possibilities - we have https mirrors that work anywhere the internets work.

@white238
Copy link
Member

white238 commented Dec 4, 2020

Can you list mirrors and it just keeps going down the list if it can't access them?

@adrienbernede
Copy link
Member Author

Of course we can do something more advanced. I was trying to adjust the effort to the minimum requirement.
In general, the way we handle the configuration lack some uniformity and robustness.
We could rely more on Spack commands now that they exists (like the one you showed me yesterday @white238).

@adrienbernede adrienbernede merged commit 8addbef into master Dec 4, 2020
@adrienbernede adrienbernede deleted the feature/mirror_in_config branch December 4, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants