tweaking some of the builds

LLNL · Dec 19, 2024 · bf88c05 · bf88c05
1 parent 55e0955
commit bf88c05
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["scikit-build-core >=0.10", "nanobind >=2.4.0","cmake>=3.22"]
+requires = ["scikit-build-core >=0.10", "nanobind >=2.4.0"]
 build-backend = "scikit_build_core.build"
 
 [project]

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
@@ -28,7 +28,7 @@ find_package(nanobind CONFIG REQUIRED)
 
 nanobind_add_module(units_llnl NB_STATIC STABLE_ABI src/units_python.cpp)
 
-target_link_libraries(units_llnl PUBLIC units::units)
+target_link_libraries(units_llnl PRIVATE units::units)
 
 # Install directive for scikit-build-core
 install(TARGETS units_llnl LIBRARY DESTINATION units_llnl)
diff --git a/units/CMakeLists.txt b/units/CMakeLists.txt
@@ -130,6 +130,7 @@ elseif(UNITS_BUILD_STATIC_LIBRARY)
     )
     target_link_libraries(units PRIVATE compile_flags_target)
 
+    set_target_properties(units PROPERTIES POSITION_INDEPENDENT_CODE ON)
     if(UNITS_ENABLE_TESTS)
         target_compile_definitions(
             units PUBLIC -DENABLE_UNIT_TESTING=1 -DENABLE_UNIT_MAP_ACCESS=1