Report GPU power limit using the correct NVML API #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
nvmlDeviceGetPowerManagementLimit()
call by thenvmlDeviceGetEnforcedPowerLimit()
. The former API does not report the updated GPU power limit if it has been modified via. an out-of-band interface. For example, if the GPU power limit is implicitly updated by the node power limiting interface on Lassen, the updated GPU power limit is not reflected in the output of the former API. The latter API (i.e.,nvmlDeviceGetEnforcedPowerLimit()
) captures the changes in the GPU power limit applied through both the in-band interface (e.g.,nvidia-smi
or NVML) as well as the out-of-band interface (e.g., IBM node power limit interface).Fixes #445
Type of change
How Has This Been Tested?
This fix has been tested on Lassen. Following test cases have been performed:
nvidia-smi
(i.e., in-band). Result: Passnvidia-smi
(in-band). Result: PassChecklist:
./scripts/check-code-format.sh
and confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON
)Thank you for taking the time to contribute to Variorum!