Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this fix NVML can't be found via standard CMake variables. With this, I can do
do find
NVML
. Requiring finding the include file and library also makes the error message at the end obsolete. Of course, it's up for discussion what the best error message is and I'm happy to change accordingly.Finding
CUDAToolkit
allows me to configure without specifying any extraCMake
arguments since the path is deduced from thenvcc
location.Also
Variorum
was linking againstNVML_HEADER
instead ofNVML_LIBRARY
resulting in link failures even when the library was found.Type of change
How Has This Been Tested?
Configuring and building in a docker container based on top of
nvidia/cuda:11.7.1-devel-ubuntu22.04
viaTest before merge:
Checklist:
./scripts/check-code-format.sh
and confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON
)