Fix compatibility with ROCm < 6.0.0 #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core needs to be prefixed to find the rocm_version.h header
|
@masterleinad Can you check the build at your end again? We're setting Are you creating host-configs are your end similar to this one from Tioga, for example? If so, could you commit the Frontier host config as well, so other Frontier users can reproduce your build? |
masterleinad
commented
Jun 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frontier currently only has rocm/6.0.0 which is unusable because of ROCm/ROCm#2752. 192a58d switched to the interface for ROCm 6.0.0 and higher while commenting the necessary code for earlier versions. This pull request restores the compatibility by checking for
ROCM_VERSION_MAJOR.Fixes #513.
Type of change
How Has This Been Tested?
Running the tests on
Frontierwithrocm-5.7.1.Test before merge:
Note: Using Rocm 5.7.1 on Tioga results in a warning with `/usr/tce/packages/gcc/gcc-10.3.1/bin/ld: warning: librocm_smi64.so.6, needed by /lib/../lib64/libhwloc.so, may conflict with librocm_smi64.so.5. The power data generated from variorum-print-power-example is correct. This warning doesn't have to do with the PR's fix but rather the fact that GCC is built with a newer ROCm in our toolchain. We expect to use the newer version, and this was a test for backward compatibility, so declaring this test as successful.
Checklist:
./scripts/check-code-format.shand confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON)