Remake functions #917
Remake functions #917
Conversation
| const map = { | ||
| 'strong': { | ||
| constant: REGEXP_STRONG, | ||
| callback: strong |
There was a problem hiding this comment.
it will not work because you didn't import it
| }, | ||
| 'empty': { | ||
| constant: REGEXP_HTML_COMMENTS, | ||
| callback: comments |
| } | ||
| } | ||
|
|
||
| function replaceMarkdown(callback) { |
There was a problem hiding this comment.
rename the name of argument, please because it's not callback - it's a name for example just name
src/callbacks/replace-md.js
Outdated
| // console.log('helpers- replace markdown method') | ||
| // console.log(typeof callback) | ||
|
|
||
| const str = map.callback |
There was a problem hiding this comment.
while calling map.strong will return object with constant and callback not a string rename it please
There was a problem hiding this comment.
map.callback it will not work because because you have to call like this map[name] then you will get object
checkFolders.js
Outdated
| // isFolderExists('./src/parserMDReact/tests/_generated'); | ||
|
|
||
| function isFolderExists(dir) { | ||
| if (!existsSync(dir)) { |
There was a problem hiding this comment.
you need to import function isFolderExists from utils and use it or in this case import this function from fs
src/callbacks/replace-md.js
Outdated
| // console.log('helpers- replace markdown method') | ||
| // console.log(typeof callback) | ||
|
|
||
| const str = map.callback |
There was a problem hiding this comment.
map.callback it will not work because because you have to call like this map[name] then you will get object
src/callbacks/replace-md.js
Outdated
| } | ||
| } | ||
|
|
||
| function Markdown(callback) { |
There was a problem hiding this comment.
название функции не нужно было менять нужно было просто поменять название аргумента на name
There was a problem hiding this comment.
верните обратно название функции
| // console.log('helpers- replace markdown method') | ||
| // console.log(typeof callback) | ||
|
|
||
| const LocalObject = map[callback] |
There was a problem hiding this comment.
уже лучше но название константы сделайте другой начиная с маленькой буквы
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "build": "rollup -c", | |||
| "parse": "npm run build && cross-env PARSE=full node ./dist/bundle", | |||
| "parse": "babel src --out-dir lib && cross-env PARSE=full node ./dist/bundle", | |||
There was a problem hiding this comment.
не будет никогда работать переделайте
checkFolders.js
Outdated
| isFolderExists('./src/tests/_generated'); | ||
| isFolderExists('./src/parserMDReact/tests/_generated'); | ||
|
|
||
| function isFolderExists(dir) { |
| @@ -0,0 +1,11 @@ | |||
| const { isFolderExists } = require('./src/utils'); | |||
There was a problem hiding this comment.
да правильно но проблема в том что это не будет работать потому что код написан в es6 и даст ошибку при запуске
There was a problem hiding this comment.
нужно придумать решение чтобы при запуске тестов это работало
No description provided.