fromfreelance #923
fromfreelance #923
Conversation
|
This pull request fixes 4 alerts when merging d0c4e50 into d4cab74 - view on LGTM.com fixed alerts:
|
| try { | ||
| let fixedCallbackMethod = false; | ||
|
|
||
| if (!typeof callback) { |
There was a problem hiding this comment.
можете вернуть обратно этот кусок кода, и выкидывать ошибку в случае если нету имени?
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "cross-env": "7.0.3", | |||
| "lodash": "4.17.21", | |||
| "path-exists": "5.0.0", | |||
| "pixel-email-cli": "^0.2.0", | |||
There was a problem hiding this comment.
а зачем вы установили пакет?
src/callbacks/replace-md.js
Outdated
| }, | ||
| 'previewText':{ | ||
| constant: REGEXP_PREVIEW_TEXT, | ||
| callback: previewText | ||
| replacer: previewText |
There was a problem hiding this comment.
а где импорт для previewText?
src/callbacks/replace-md.js
Outdated
| }, | ||
| 'empty': { | ||
| constant: REGEXP_HTML_COMMENTS, | ||
| callback: comments | ||
| replacer: comments |
There was a problem hiding this comment.
можете закоментить код, так как нету импорта?
src/callbacks/replace-md.js
Outdated
| }, | ||
| 'blockquote': { | ||
| constant: REGEXP_BLOCKQUOTE, | ||
| callback: blockQuote | ||
| replacer: blockQuote |
There was a problem hiding this comment.
импортируеться blockquote а здесь по другому названо?
src/callbacks/replace-md.js
Outdated
| }, | ||
| 'separator': { | ||
| constant: REGEXP_SEPARATOR, | ||
| callback: separator | ||
| replacer: separator |
src/callbacks/replace-md.js
Outdated
| }, | ||
| 'REGEXP_EMPTY_OL': { | ||
| constant: REGEXP_EMPTY_OL, | ||
| callback: emptyOl | ||
| replacer: emptyOl |
There was a problem hiding this comment.
можете закоментить код, так как нету импорта?
|
This pull request fixes 4 alerts when merging 5f4b357 into d4cab74 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 9bd8151 into d4cab74 - view on LGTM.com fixed alerts:
|
From freelance Viktor Shlapak