Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for lcalc files #1257

Closed
davidfarmer opened this issue May 9, 2016 · 10 comments
Closed

Tests for lcalc files #1257

davidfarmer opened this issue May 9, 2016 · 10 comments
Labels
L-functions L-functions
Milestone

Comments

@davidfarmer
Copy link
Member

If we are going to have links to Lcalc files, then we need to have tests for them.

@davidfarmer davidfarmer added the L-functions L-functions label May 9, 2016
@AndrewVSutherland AndrewVSutherland added this to the v1.2 milestone Jul 11, 2016
@JohnCremona
Copy link
Member

What sort of tests? Adding tests to make sure that the links work, that's easy. Testing that the code then runs is much harder and might be impossible. We try (I hope) to make sure that the Sage / Magma / GP code does work, but I do not know a way to automate that and occasionally there is a problem.
I'm sure that there is someone out there who could write a script which would download some of these code files and run the code and compare the output with a precomputed standard, which could be run at least locally. Getting Travis to do this is a rather harder job (and impossible for Magma, not being free or easy to install).

@edgarcosta
Copy link
Member

I think we should serve the Lcalc files with a disclaimer along the lines:

Many of the properties of the L-functions are pre-computed and require many more Dirichlet coefficients than the ones stored on our database, hence the ones provided in this Lcalc file.

One could also add a line saying that these are just meant as mock up examples.

@davidfarmer
Copy link
Member Author

Closing, because we don't want any links to lcalc: all the L-function values should be served
from the database.

We could open another issue to eliminate lcalc, but that probably is not necessary because
it should be automatic once all the L-function data is precomputed.

@davidfarmer
Copy link
Member Author

Reopening because there should be some discussion about whether lcalc files or an alternative
should be available as a way to download that data.

@AndrewVSutherland
Copy link
Member

Perhaps these should be viewed in the same category as the code snippets we have on many pages, which provide a way for a user to reconstruct an object or some of its attributes in an external software package, but these code snippets do not necessarily represent the method used to compute the data that appears on the page. For example, on an elliptic curve page you can click the Magma button to get a code snippet to compute generators for the Mordell-Weil group in Magma, but that is not how the generators stored in the LMFDB were computed, and if if your this code in Magma you will not necessarily get the same generators that appear on the page. But I think the code snippet is still useful.

@edgarcosta
Copy link
Member

edgarcosta commented May 23, 2018 via email

@edgarcosta
Copy link
Member

Should we add a disclaimer to the header of the files?

@AndrewVSutherland
Copy link
Member

AndrewVSutherland commented Oct 6, 2018

At the LMFDB editorial meeting in August we agreed to remove the L-calc links, but this won't happen until after the postgres conversion is complete and the new modular forms code with precomputed L-functions is live. But I'm happy to leave this issue open until the situation is resolved. There is nothing wrong with adding a disclaimer in the mean time if someone wants to do it.

@edgarcosta
Copy link
Member

edgarcosta commented Oct 6, 2018 via email

@AndrewVSutherland
Copy link
Member

With #2717 merged the postgres version is now running on www.lmfdb.org and L-calc links no longer appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-functions L-functions
Projects
None yet
Development

No branches or pull requests

4 participants