-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for lcalc files #1257
Comments
What sort of tests? Adding tests to make sure that the links work, that's easy. Testing that the code then runs is much harder and might be impossible. We try (I hope) to make sure that the Sage / Magma / GP code does work, but I do not know a way to automate that and occasionally there is a problem. |
I think we should serve the Lcalc files with a disclaimer along the lines:
One could also add a line saying that these are just meant as mock up examples. |
Closing, because we don't want any links to lcalc: all the L-function values should be served We could open another issue to eliminate lcalc, but that probably is not necessary because |
Reopening because there should be some discussion about whether lcalc files or an alternative |
Perhaps these should be viewed in the same category as the code snippets we have on many pages, which provide a way for a user to reconstruct an object or some of its attributes in an external software package, but these code snippets do not necessarily represent the method used to compute the data that appears on the page. For example, on an elliptic curve page you can click the Magma button to get a code snippet to compute generators for the Mordell-Weil group in Magma, but that is not how the generators stored in the LMFDB were computed, and if if your this code in Magma you will not necessarily get the same generators that appear on the page. But I think the code snippet is still useful. |
I also think these should be viewed in the same category as the code
snippets.
…On 23 May 2018 at 09:58, Andrew Sutherland ***@***.***> wrote:
Perhaps these should be viewed in the same category as the code snippets
we have on many pages, which provide a way for a user to reconstruct an
object or some of its attributes in an external software package, but these
code snippets do not necessarily represent the method used to compute the
data that appears on the page. For example, on an elliptic curve page you
can click the Magma button to get a code snippet to compute generators for
the Mordell-Weil group in Magma, but that is not how the generators stored
in the LMFDB were computed, and if if your this code in Magma you will not
necessarily get the same generators that appear on the page. But I think
the code snippet is still useful.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1257 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATtBlgDSo5abGwH0-n_WOeeIKb0B3krks5t1WrpgaJpZM4IabMH>
.
|
Should we add a disclaimer to the header of the files? |
At the LMFDB editorial meeting in August we agreed to remove the L-calc links, but this won't happen until after the postgres conversion is complete and the new modular forms code with precomputed L-functions is live. But I'm happy to leave this issue open until the situation is resolved. There is nothing wrong with adding a disclaimer in the mean time if someone wants to do it. |
Great. That is what I was hoping for.
I will remove them together with the other changes associated to classical
modular forms.
…On Sat, Oct 6, 2018, 12:10 Andrew Sutherland ***@***.***> wrote:
At the LMFDB editorial meeting in August we agreed to remove the L-calc
links, but this won't happen until after the postgres conversion is
complete and the new modular forms code with precomputed L-functions is
live. But I'm happy to leave this issue open until the situation is
resolved. There is certainly fine with adding a disclaimer in the mean time
if someone wants to do it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1257 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATtBoC2iAQh6we0jX7klJk4oxFLK7Duks5uiNXggaJpZM4IabMH>
.
|
With #2717 merged the postgres version is now running on www.lmfdb.org and L-calc links no longer appear. |
If we are going to have links to Lcalc files, then we need to have tests for them.
The text was updated successfully, but these errors were encountered: