Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track muting doesn't work #1512

Closed
curlymorphic opened this issue Dec 26, 2014 · 2 comments
Closed

track muting doesn't work #1512

curlymorphic opened this issue Dec 26, 2014 · 2 comments
Labels
Milestone

Comments

@curlymorphic
Copy link
Contributor

This issue was on the mailing list. copying here for completeness.

track muting doesn't work
Probably caused by recent changes in NotePlayHandles and AudioPorts. I
think this can be fixed in AudioPort, where all the NPH's output is
mixed to the AudioPort - add a check if the instrument track that is
associated with the AudioPort is muted, and if so, skip the processing
of the AudioPort, including its fx chain, and don't write its output to
the FxMixer.

@Sti2nd
Copy link
Contributor

Sti2nd commented Dec 26, 2014

Is this in master? I know we previously had that problem, but I think it went away, or else it should be an open bug report somewhere.

@tresf tresf added the bug label Dec 26, 2014
@tresf tresf added this to the 1.2.0 milestone Dec 26, 2014
@badosu
Copy link
Contributor

badosu commented Dec 26, 2014

@Sti2nd I reproduced it for latest master (1cd8c0e) on Linux 64bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants