Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note-block context menu : Clean all notes If vol <= 1 #2155

Closed
musikBear opened this issue Jul 3, 2015 · 5 comments
Closed

note-block context menu : Clean all notes If vol <= 1 #2155

musikBear opened this issue Jul 3, 2015 · 5 comments

Comments

@musikBear
Copy link

If someone would implement a new item in note-block context menu allowing the user to delete notes in that specific block, if note-volume <=1, then LMMS has ghost-notes!
( '0' may be too hard a rule, '0.1' would properly be fool-safe

First a dev need to chime in and say if this can be done relatively 'easy', and without conflicts, then this can function as perfect ghosts-notes, in combination with other already existing features:

Take the block you want as ghost
Duplicate it to the track where you want to compose over the ghosts
Mark all
Drag volume to 0
Move these note one semitone up
Unmark all
Compose -except, dont place notes on the existing notes, instead place notes one semitone below 'ghosts'
Close piano-roll
Open my requested new method
Delete all 0-vol notes ('ghosts')
Job done

But -can 'delete all notes with volume < 1' be implemented ?
Or does noone care :p

@musikBear musikBear changed the title enhancement -creep-feature- note-block context menu : Clean all notes If vol <= 0 enhancement -creep-feature- note-block context menu : Clean all notes If vol <= 1 Jul 6, 2015
@musikBear musikBear changed the title enhancement -creep-feature- note-block context menu : Clean all notes If vol <= 1 creep-feature- note-block context menu : Clean all notes If vol <= 1 Jul 16, 2015
@curlymorphic
Copy link
Contributor

This does not sound like a correct solution to me, more of work around, with the key feature to this workaround being an unimplemented hack.

If there is a valid use for this function, or if it can be decided that this is a valid use case, I can see no reason why this could not be implemented with relative ease in the piano editor.

@tresf
Copy link
Member

tresf commented Jul 16, 2015

@musikBear can you please remove the creeper wording from the title and body. image

@tresf
Copy link
Member

tresf commented Jul 16, 2015

First a dev need to chime in and say if this can be done relatively 'easy', and without conflicts, then this can function as perfect ghosts-notes, in combination with other already existing features:

First, you need to explain the problem, how to reproduce, and in this case your proposed workaround. 👍 That should be the first part anyone reads in your bug report. Any supplemental reading can be added as notes to the bottom.

@musikBear musikBear changed the title creep-feature- note-block context menu : Clean all notes If vol <= 1 note-block context menu : Clean all notes If vol <= 1 Jul 16, 2015
@musikBear
Copy link
Author

@curlymorphic i understand what you mean. There is no real general benefit from deleting notes < 1 in other circumstances, that is true.
I actually also thought of two different ways to accomplish the same thing
The first has to do with the behavior in piano-roll's volume-section.
Current right-mouse implementation will delete the notes if the mouse passes the bar.
If the delete behavior was redesigned to selection and restricted to collision with the bar, the same workflow could be achieved. This behavior could be more general useful, but also a more complex method.

The 2. thought i had, was addressing the behavior in general selection.
Current design will de-select all selected notes in piano-roll, when a new note is inserted.
If the selections could be preserved, until the user made a deliberate action, then it would also be possible to get rid of the 'ghosts' after composing.
Again this method could have several general usages, but i again saw this as a more complex implementation.
If you have any thoughts around this, in respect to complexity and or usability, i would be very interested. (unfortunately your fine tutorial on QT, made me realize, that i do not have hw remotely sufficient for working on lmms, besides that i am also only capable in AS for flash, cpp has a much higher complexity level, but my inadequateness is not relevant here :)

@zonkmachine
Copy link
Member

then LMMS has ghost-notes!

Right. If I understand this correct you are suggesting a method to implement 'ghost notes' but this already has an issue of it's own. Closing this as a duplicate of #520.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants