Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll Ghost notes #520

Closed
DoosC opened this issue Mar 27, 2014 · 32 comments
Closed

Piano Roll Ghost notes #520

DoosC opened this issue Mar 27, 2014 · 32 comments

Comments

@DoosC
Copy link

DoosC commented Mar 27, 2014

Background sequences could be very useful in the piano roll view, see for example : http://ariamaestosa.sourceforge.net/docs/background.png

@diizy
Copy link
Contributor

diizy commented Mar 27, 2014

On 03/27/2014 11:14 PM, DoosC wrote:

Background sequences could be very useful in the piano roll view, see
for example : http://ariamaestosa.sourceforge.net/docs/background.png

This has also been discussed IIRC, should be implemented at some point...

@pgiblock
Copy link
Contributor

I don't understand

@diizy
Copy link
Contributor

diizy commented Mar 27, 2014

On 03/28/2014 12:23 AM, Paul Giblock wrote:

I don't understand

Showing notes of other patterns in the background of the piano roll (at
least I think this issue is about that)

@musikBear
Copy link

ghostnotes +1

@DoosC
Copy link
Author

DoosC commented Mar 29, 2014

Yes I meant ghostnotes !
It's a powerfull composing tool, see how it is used with great benefit in this tutorial : http://www.midichords.com/posts/from-chord-progression-to-hymn-of-the-last-whale

@lukas-w lukas-w changed the title [enhancement] Background sequence Piano Roll Ghost notes Nov 25, 2014
@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@musikBear @tresf @DoosC Can you help me design this feature?

Apart from the ghost note drawing design, I have some questions:

  1. How do we define which patterns will be ghosted?
  2. In which piano-rolls should the ghost notes appear?

@musikBear
Copy link

I mailed you a design idea a good week ago .. at least i thought i did :p -Same profile picture.. so i thought ..mm If not his evil twin, then same person :D
It should be in your mail-list inbox?
but it is essential what i wrote here on 8 May 2014: #696
I now know that there are one snag -All note-events are processed by the engine, also if they have 0 volume (diiz told me) Also setting notes to negative volume (-1) could that be a problem? -but the design in #696 would also work if the notes are set to 0.
If there is anything unclear or just garbadge, dont hesitate to ping me here

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 28, 2015

  1. Could be right click on a pattern i Song Editor and "Choose as ghost reference"
  2. Are there several Piano Rolls? Are you doing this as well Split(Dual) View Piano Rolls #1438 ?

@tresf
Copy link
Member

tresf commented Jan 28, 2015

I mailed you a design idea a good week ago .. at least i thought i did :p -Same profile picture.. so i thought ..mm If not his evil twin, then same person :D

Don't do this please, use our tracker instead so there's no doubt.

Here's the picture hotlinked above, which I feel is adequate for a visual representation:

image

As far as @badosu's questions about "which notes", I have a hard time envisioning that too.... There's a lot of potential patterns and tracks to choose from, so the enhancement should go as far as to offer HOW this will be selected, not just WHY. Because if there's no HOW, we can't fix it and we can never close this bug report.

@DoosC
Copy link
Author

DoosC commented Jan 28, 2015

As @Sti2nd suggested, right-clicking on the current piano roll to select a "ghost track" seems fine. An icon with a small ghost right on the piano rool toolbar would be nice too ;) Something like this : 👻
Right-clicking either on the piano roll or on the ghost would then bring a hierarchical drop-down menu : level 1 would be the track name as in the song editor, and level 2 would be the clip number for the selected (level 1) track.
For example :

🔽 Kick
- Kick 1
- Kick 2
- Kick 3
- Kick 4
▶️ Snare

Does that sound feasible ?

@tresf
Copy link
Member

tresf commented Jan 28, 2015

Does that sound feasible ?

What if the track has multiple different patterns?

image

@DoosC
Copy link
Author

DoosC commented Jan 28, 2015

That's why I mentionned levels, in this case you would have :

🔽 Track 1
- Track 1 - 1
- Track 1 - 2

Level 1 is the track, and level the pattern.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 28, 2015

What if the track has multiple different patterns?

What? You can only open one pattern at a time in Piano Roll now, what makes you think ghost notes would work different?

right-clicking on the current piano roll to select a "ghost track"

I meant and wrote right clicking on the pattern (with arrows).
image

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 28, 2015

Are you suggesting using the pattern at the same time of the one in Piano Roll @DoosC ?

Like this?
image
It might be that you most of the time are going to compare patterns at the same time, but I feel it could be even more universal and not so limiting if you could just right click and choose "open as ghost notes in Piano Roll" on a pattern. Also with time implementation you have the problem of choosing between several patterns at the same time interval as the other, as my image show in the first and second bar.
I think both the simplest and best implementation is to choose a pattern that you can open as ghost notes. It will stay there when you open other Piano Rolls, or until you turn off ghost note mode.

@DoosC
Copy link
Author

DoosC commented Jan 28, 2015

@Sti2nd you are right, it could be much simpler to do it visually.
Procedure : you left click on a pattern = you have it on the piano roll, you right click and choose "open as ghost notes in Piano Roll" and there you are, no need for cluttered drop-down lists.
The main use case is as you said comparing patterns.
Brilliant !

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@DoosC @Sti2nd This is a nice idea, I thought about something on these lines as well.

Now comes another question, can more than one block be selected to show as ghost notes? I'd vote to have just one for now, and if this feature becomes popular and there's demand to change it, we change it :-).

Also, is this copyright issue with the "Ghost notes" name serious? If it is, we'll have to find another name.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 28, 2015

I'd vote to have just one for now

Ok, one is better than none! I don't know about the name. I have found threads about ghost notes for both FL Studio, Ableton and Reaper, so I think it is strange... @musikBear

@tresf
Copy link
Member

tresf commented Jan 28, 2015

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@tresf Your link refers to this name in a different context than what we're talking about.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

@tresf Your link refers to this name in a different context than what we're talking about.

It bears many similarities to what we are describing though, notably: dead note, muted note, silenced note or false note.

The point though is that the term can't really be plagiarized. Regardless of whether or not it is a good word for this context, there shouldn't be an copyright-type-hesitations when using it in the software, right?

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 28, 2015

there shouldn't be an copyright-type-hesitations when using it in the software, right?

If FL studio had that copyrighted it would probably be that very same feature, and that would be a problem. However I can't imagine that is the case. Lots of software have this.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@tresf

...there shouldn't be an copyright-type-hesitations when using it in the software, right?

I really don't know, copyright law is a infinite headed beast :-(. But if you say that we can do it, let's do!

@musikBear
Copy link

@Sti2nd sugestion is fine, it is almost how i thought about it, i just omitted the part where the engine takes care of the copy process.
I simply thought about a manual track clone (as we have already) and then on the new clone an option for "make this track into 'ghosts' "
So use already existing methods to most of the process
That would only need
context-item :ghost this trac + method
method 'remove-ghosts' -should be pr block not for whole track -and only nessesary because of cpu-load, (because also 0-volume-notes are processed as real note-events)

I will try to look into the web-documentation, and see if image-line actually has any protection on the term, but if lmms used like
phantoms
glass
follow
-notes
Then no problem

@musikBear
Copy link

Have search true the online docs for fl-studio. This is where they describe the feature:

Ghost channels ( Alt+V) - When selected, the Piano roll will show the scores of all channels in the current pattern (they are displayed in the background and have a semi-transparent look). Note that these scores are displayed only as a reference for easier sequencing. Select ghost notes by double Right-clicking to change the selected Channel.

So they mentions ghost-channels and ghost-notes -However non of the words has a marking for copyright or alike, so i dont think theres any protection of either term. However, other 'names' that would be expected to be protected, like 'PoiZone' has no marking either.. idk..
I found the text here:
http://www.image-line.com/support/FLHelp/

If i find something il post it here, ofcause

@tresf
Copy link
Member

tresf commented Jan 29, 2015

Here's an excerpt from a US copyright office flyer that I think helps explain (via copyright.gov):

Copyright law does not protect names, titles, or short phrases or expressions. Even if a name, title, or short phrase is novel or distinctive or lends itself to a play on words, it cannot be protected by copyright. The Copyright Office cannot register claims to exclusive rights in brief combinations of words such as:

  • Names of products or services
  • Names of businesses, organizations, or groups (including the names of performing groups)
  • Pseudonyms of individuals (including pen or stage names)
  • Titles of works
  • Catchwords, catchphrases, mottoes, slogans, or short advertising expressions
  • Listings of ingredients, as in recipes, labels, or formulas. When a recipe or formula is accompanied by an explanation or directions, the text directions may be copyrightable, but the recipe or formula itself remains uncopyrightable.

So in this case, we are using a brief combination of words and commercial DAWs cannot make claims of exclusivity because it is a common phrase and existed long before the commercial software was invented. (I think. 👍 )

@musikBear
Copy link

well i found a contact form, so i just asked them.
*Hi, could you please tell me, wheater or not the terms
'Ghost-notes'
ao.
'Ghost-channels'
are registraded trademarks, or in other ways protected or own by image-line or affilate owners

  • or are they just 'words' :)
    Just dont want to start any leagal mess, so thats why we ask you.
    tyia
    Br. A Jensen*
    They have 3-4 days at. on un-registrated user questions
    Then we know, and there are no traps or sticky paper

@tresf
Copy link
Member

tresf commented Jan 29, 2015

well i found a contact form, so i just asked them.

This is not to be taken personally, but I'd prefer you not to communicate on behalf of the project without discussing first. the /way/ you type msgs smtimes * may not be ideal 'way' 4 our. Proj. (especially when communicating with a professional software company such as Image-Line).

@tresf
Copy link
Member

tresf commented Jan 29, 2015

Furthermore, now if they come back and say "No, LMMS can't use 'Ghost Notes'", we're in an even worse position when we decide to use the term.

@musikBear
Copy link

...lmms are no where mentioned what so ever (im not a total retard :)
I aproached IL as a private citizen of the infinity that is cyberspace
..but imo - a clear yes or no is the best - dont you agree -why speculate and perhaps even get muddy in a seshpool of leagal c***

@tresf
Copy link
Member

tresf commented Jan 29, 2015

dont you agree -why speculate and perhaps even get muddy in a seshpool of leagal c***

No, I don't agree. We should never ask permission. This same question came up for our use of the word "Native instruments" on our home page (which is more likely to cause controversy than a measly "Ghost Notes").

I aproached IL as a private citizen of the infinity that is cyberspace

If someone searches your name and email, they'll find you're involved in the project. Please don't try to make that argument. 😺

@lukas-w
Copy link
Member

lukas-w commented Apr 22, 2018

Closing this one as duplicate of #4303 because #4303 has a better issue description.

@ghost
Copy link

ghost commented Sep 1, 2018

I have something working, will put in a PR one of these days. Still need to clean up some code before putting anything online, then add some more user feedback.

Ghost notes feature

@ghost ghost mentioned this issue Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants