Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency: change "--loop-mode" command-line option to "--loopmode" #2258

Closed
M374LX opened this issue Aug 13, 2015 · 3 comments
Closed

Comments

@M374LX
Copy link
Contributor

M374LX commented Aug 13, 2015

If one looks at the command-line options, no one except --loop-mode has a hyphen in the middle: --samplerate, --bitrate, --oversampling, --allowroot.

Thus, for consistency reasons, I suggest changing it to --loopmode.

There is another detail: the output of --help lists --output-format as an option, but it is actually --format.

@Wallacoloo
Copy link
Member

I'm pretty neutral as to the hyphen vs non-hyphen discrepancy, so I'll just see what others have to say.

Another thing is that the help for the bitrate option says:

-b, --bitrate <bitrate>     specify output bitrate in kHz
                            default: 160.

The dimensions there are incorrect. bitrate is bits/[time], whereas Hz is just 1/[time]. My guess is that the intention was for the unit to be kbps (and I'm thinking this only applies to ogg export).

@M374LX
Copy link
Contributor Author

M374LX commented Aug 13, 2015

Another possibility is shortening it further to --loop, as in #2131.

@tresf
Copy link
Member

tresf commented Aug 24, 2015

Thanks. Changed to --loop per 2nd suggestion. Also addressed other typos via de40aa8.

ThomasJClark pushed a commit to ThomasJClark/lmms that referenced this issue Sep 12, 2015
M374LX pushed a commit to M374LX/lmms that referenced this issue Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants