-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency: change "--loop-mode" command-line option to "--loopmode" #2258
Comments
I'm pretty neutral as to the hyphen vs non-hyphen discrepancy, so I'll just see what others have to say. Another thing is that the help for the bitrate option says:
The dimensions there are incorrect. bitrate is bits/[time], whereas Hz is just 1/[time]. My guess is that the intention was for the unit to be kbps (and I'm thinking this only applies to ogg export). |
Another possibility is shortening it further to |
Thanks. Changed to |
Closes LMMS#2258
If one looks at the command-line options, no one except
--loop-mode
has a hyphen in the middle:--samplerate
,--bitrate
,--oversampling
,--allowroot
.Thus, for consistency reasons, I suggest changing it to
--loopmode
.There is another detail: the output of
--help
lists--output-format
as an option, but it is actually--format
.The text was updated successfully, but these errors were encountered: