Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossover equalizer: distortion from dials #3339

Closed
musikBear opened this issue Feb 9, 2017 · 2 comments
Closed

crossover equalizer: distortion from dials #3339

musikBear opened this issue Feb 9, 2017 · 2 comments

Comments

@musikBear
Copy link

RC.2.8 win 32
This image shows random notes with automation of the 1/2-dial in crossover equalizer
crossoverbuttons
Listen to this recording
https://soundcloud.com/musikbear/crossoverdials
The distorting are where the slope of the automation-track makes the dial turn
The clean sound is on the plateaus
Can that be fixed?

michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Feb 10, 2017
Do not clear the filter histories when the crossover control has changed,
e.g. via automation.

Add a new method CrossoverEQEffect::clearFilterHistories that's called
whenever the filter histories need to be cleared, e.g. after loading a
crossover EQ. It would be beneficial to also call this method when the
effect is enabled again after being disabled but it seems there is no
was to find out that this event has happened. One could implement it in
the process method by storing the current state in a member and
comparing it to the state at the time of the last process call but this
is something that should be provided by the framework.
@michaelgregorius
Copy link
Contributor

Should be fixed with #3343.

zonkmachine pushed a commit that referenced this issue Mar 8, 2017
Do not clear the filter histories when the crossover control has changed,
e.g. via automation.

Add a new method CrossoverEQEffect::clearFilterHistories that's called
whenever the filter histories need to be cleared, e.g. after loading a
crossover EQ. It would be beneficial to also call this method when the
effect is enabled again after being disabled but it seems there is no
was to find out that this event has happened. One could implement it in
the process method by storing the current state in a member and
comparing it to the state at the time of the last process call but this
is something that should be provided by the framework.
@zonkmachine
Copy link
Member

Closed in #3343

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
…MMS#3343)

Do not clear the filter histories when the crossover control has changed,
e.g. via automation.

Add a new method CrossoverEQEffect::clearFilterHistories that's called
whenever the filter histories need to be cleared, e.g. after loading a
crossover EQ. It would be beneficial to also call this method when the
effect is enabled again after being disabled but it seems there is no
was to find out that this event has happened. One could implement it in
the process method by storing the current state in a member and
comparing it to the state at the time of the last process call but this
is something that should be provided by the framework.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants