Move search and refresh fields above file navigator #3657
Comments
|
Also adding a "Search" placeholder text in the text box would help. Here's the concept image:
|
|
Great proposal! |
…S#3657) Move the search bar on top of the file browser for the following sidebar windows: * "My Projects" * "My Samples" * "My Presets" * "My Home" * "My Computer" Also rename some variable names to something more meaningful. Rename the member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the following local variables in the constructor of FileBrowser: * ops -> searchWidget * opl -> searchWidgetLayout
|
Move of the search bar to the top is implemented in pull request #3662 which is based on |
|
Commit 96b136f adds the placeholder text "Search". This is how it currently looks: Adding the default text was one line and much simpler than I would have thought. Qt for the win! 😄 |
|
How does it look in the classic theme? |
|
@Mark-Agent003 This is how it looks with the classic theme: |
|
@michaelgregorius Nicely done! |
|
@Mark-Agent003 why do you closed this issue? |
|
Reopening this one so it can be closed once #3662 is integrated. |
|
I closed it because we already had a pull request open for this, and I didn't think we needed two separate discussions about the same thing. Do we actually need this open? |
|
Yes, because it will be closed once the pull request is merged |
|
Ok, that's fine |
|
Shall I merge this one? |
👍 from me. |
|
Tested. Works much better on top! |
…S#3657) Move the search bar on top of the file browser for the following sidebar windows: * "My Projects" * "My Samples" * "My Presets" * "My Home" * "My Computer" Add the greyed out text "Search" to the search text edit. The text is only shown as long as no text is entered in the search field. Also rename some variable names to something more meaningful. Rename the member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the following local variables in the constructor of FileBrowser: * ops -> searchWidget * opl -> searchWidgetLayout
Move the search bar on top of the file browser for the following sidebar windows: * "My Projects" * "My Samples" * "My Presets" * "My Home" * "My Computer" Add the greyed out text "Search" to the search text edit. The text is only shown as long as no text is entered in the search field. Also rename some variable names to something more meaningful. Rename the member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the following local variables in the constructor of FileBrowser: * ops -> searchWidget * opl -> searchWidgetLayout
|
Closed with #3662. |
…S#3657) Move the search bar on top of the file browser for the following sidebar windows: * "My Projects" * "My Samples" * "My Presets" * "My Home" * "My Computer" Add the greyed out text "Search" to the search text edit. The text is only shown as long as no text is entered in the search field. Also rename some variable names to something more meaningful. Rename the member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the following local variables in the constructor of FileBrowser: * ops -> searchWidget * opl -> searchWidgetLayout
Moving the search field and the refresh button to the top of the file navigator would help the user's experience in many ways. It would:
Bring it to the direction of the user's eye (Then nobody has to "search" for the search)
Make it where people actually know it exists (I've heard many times of people not even knowing it existed)
Make the search more standard (you don't see Google's search on the bottom of the page)
(I may be able to provide some concept pictures tomorrow)
Thanks
The text was updated successfully, but these errors were encountered: