Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel track rename with Escape key #3675

Closed
M374LX opened this issue Jul 1, 2017 · 0 comments
Closed

Cancel track rename with Escape key #3675

M374LX opened this issue Jul 1, 2017 · 0 comments

Comments

@M374LX
Copy link
Contributor

M374LX commented Jul 1, 2017

On 1.2.0-rc3, when the user tries to rename a track on the song editor, it is not possible to cancel the action by pressing the Escape key.

Allowing the user to do so would improve the usability.
@M374LX M374LX mentioned this issue Jul 1, 2017
Merged
tresf added a commit that referenced this issue Jul 14, 2017
@tresf
Merge pull request #3676 from M374LX/stable-1.2
3dfda61 
With this pull request, the user is able to cancel a track rename action by pressing the Escape key.

Also renamed rename_dlg to renameDlg in TrackLabelButton::rename() so it complies to the naming conventions.

Fixes #3675.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@tresf
Merge pull request LMMS#3676 from M374LX/stable-1.2
04a0bc7 
With this pull request, the user is able to cancel a track rename action by pressing the Escape key.

Also renamed rename_dlg to renameDlg in TrackLabelButton::rename() so it complies to the naming conventions.

Fixes LMMS#3675.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@M374LX