Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VST changes preset value on load #3847

Closed
oeai opened this issue Oct 2, 2017 · 14 comments
Closed

VST changes preset value on load #3847

oeai opened this issue Oct 2, 2017 · 14 comments
Labels

Comments

@oeai
Copy link
Contributor

oeai commented Oct 2, 2017

i'm not sure if this bugs vst, vestige or sound core
when i open in windows my vst that is bound to hardware i hear very different sound, it's not the same as i hear in another DAW with ASIO support (not WDM or else).
i didn't mention if it asks me to save preset, if yes then it changes, i'll test it.
is there some kind of save latest config for vst? and if it tries to apply, then this can lead to a crash, because some values can be dynamically changed with using different synths + presets (+fx-fx)

the other way it can change, if it is reading midi and tries to send values somehow, while midi is not enabled for the channel

@oeai
Copy link
Contributor Author

oeai commented Oct 2, 2017

well, what I see is when I change presets inside of vst, values in the window of lmms managing-vst are not changing, so it is not reading from vst\preset,
only if I press vst-sync button it changes.
so if it is changing output in anyway, then those changed inside of vst params will not actually change
solution is in auto-sync depending on choosed window, since all apps opens inside of lmms-desk
and for vst start it should read only values for lmms-managing setup, also there can be presets button inside of lmms-managing window, so when I change values I can save them or change presets without vst itself (+maybe read those presets from vst)

@zonkmachine
Copy link
Member

Is this on the latest lmms-1.2.0-RC4 ?

@oeai
Copy link
Contributor Author

oeai commented Oct 3, 2017

it was rc3, but i've tested rc4 just now and it works the same way (it tries to save preset, that wasn't really changed) and need to press button each time to sync knobs, when changing between instrument presets.
and automatization button hides all knobs for first time, then unhides, but nothing changes on third push

for example the easy way is in changing direction with switch button, so it was able to

  1. read from vst to lmms (auto)

  2. send from midi to vst -> 1

  3. send from lmms setup automation to vst

  4. send from midi to lmms automation -> 3

  5. one more position to read [notes only] from midi (4 + 1)

the better way decide it depending on input (6), so if we got some input from user, then it should change things, but user needs to have an ability to disable inputs for instrument (lock device for changes).

and for .exe .bin updates i'd suggest to write date of (pre-)release in bugfixes

@musikBear
Copy link

@oeai you mention 'VST' so does this mean that ALL VSTs has this fail, or is this one specific VST
Please try one on the testetVST-list

Regarding the sync button: YES and yes! 👍 Bi-directional sync between both the VST UI and LMMS-dial-array would be marvellous, and it would fix all VST-issues emediately, because then lmms would only need to save its own arrays values No more nonsense with the dreathed chunk
The feature could be default in every save event, not controlled or influenced by user at all. -Eg, blackboxedI
Already suggested earlier, btw

@oeai
Copy link
Contributor Author

oeai commented Oct 3, 2017

Tyrell works same way
Zebralette not reading presets to lmms at all
VST3 - no .dll, can't add any

@Umcaruje
Copy link
Member

Umcaruje commented Oct 3, 2017 via email

@oeai
Copy link
Contributor Author

oeai commented Oct 3, 2017

first synth was Proteus, one more DR-910, it don't recognizes preset changes (works through sync button) or vst changes, only sends from lmms. But if it sends only, then it can override vst setup.

In lmms device window presets not changing, until I click on that window and it doesn't change values in VST managing window anyway

@musikBear
Copy link

@oeai > device window

Wait one secd -Are you referring to the difference between selecting a VST-patch in the VST-UI, and selecting it in LMMS' UI?
It is true, LMMS will not recognize a change of patch graphically if it is made in the VST-UI, but it is changed logically, and for the VSTs in the tested-list the patch is saved inside the project, but the name is shown as 1. patch-option on the LMMS UI, however correct patch-name is shown inside the VST
@Umcaruje That behaviour is also true for Synth1, and many more

@oeai
Copy link
Contributor Author

oeai commented Oct 4, 2017

@musikBear yes, i'm about that,
and I don't know which UI will override another (if I save or render) because of that. autom. rec from vst?
and if it is not reading values on vst start or change, but sends, then error can occur, if those values == null
for example in proteus I can add 5 fxs (from about 10) and save instrument with fx as a preset

@musikBear
Copy link

@oeai imo this is only graphical, not logical. What i think is that the VSTs you have problems with, simply does not pass the 5 point test:
https://lmms.io/wiki/index.php?title=Working_with_VSTs#The_five_point_VST_test
The behaviour you describe, is also in Synth1, but the chosen patch is preserved and reloaded with all user settings.
The fact that the name is not updated in LMMS ui is correct.

@tresf tresf added the vst label Jan 5, 2018
@DomClark
Copy link
Member

It's not entirely clear to me quite what this issue is about, but it sounds like it might have been fixed by #4401.
@oeai Can you test rc7 to see if this bug still persists?

@DomClark DomClark added the response required A response from OP is required or the issue is closed automatically within 14 days. label Jan 19, 2019
@musikBear
Copy link

@DomClark I did it for Tyrell
a change of preset in VSTUI does not showup as a change in LMMS-UI, however is is changed!
Not updating the preset-name is at most a glitch, imo
An interesting thing is, that after project-reload, there is no options for selecting presets from LMMS-UI. The Select only has one item!
If a new preset is VST-selected, project saved and reloaded, it is the new preset, that is correctly listed as preset-name on Preset-display in LMMS-UI.
Bottom-line: No synch from preset-select in VST-UI with LMMS-UI
Changes on VSTUIare preserved (goes for checkbox, selects, sliders and dials) -Eg pass 5 point-test and are fully functional.

@DomClark
Copy link
Member

TyrellN6 doesn't seem to present its presets to the host in a normal manner; I've tried this in other hosts and the only available preset is the one that is currently selected. The preset name not updating is because LMMS doesn't think the preset has changed; since the plugin only exposes a single preset at once, it is always the first preset that is selected. I could fix this, but the current system for sending VST information back to LMMS is rather restricted, and since it's only a minor cosmetic issue it's not high priority for 1.2. Hopefully I (or somebody else) will get round to this for 1.3.

@DomClark DomClark removed the response required A response from OP is required or the issue is closed automatically within 14 days. label Jan 20, 2019
@Spekular Spekular mentioned this issue Mar 31, 2020
35 tasks
@Spekular
Copy link
Member

Closing and consolidating into #5433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants