-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button "hover" effect #4464
Comments
In LMMS 1.2.0 RC6, all buttons glow when pressed. |
@Sawuare, I mean the buttons should light up. Please check this theme, and you'll understand. Link: https://lmms.io/lsp/?action=show&file=11356 In the screenshot, you can see the pencil icon light up. When I used this theme, the icons light up even when we hover over them. (After downloading this file, you have to rename the file to tar.bz2) |
AFAIK, the draw mode and edit mode buttons have 3 states: hover, pressed, checked. When a button is checked, it doesn't respond to hover/pressed. That's why a checked button doesn't glow when hovered/pressed. I don't think we can change this behavior, but I think it makes sense. |
@Sawuare, I wish if the default theme could do that. This same property is applied even in LMMS Classic theme and also in the sidebar of 1.2.0 RC6 default theme, where there is a hovering function and also the item lights up on being clicked. |
It is possible with CSS(check+hover for example): 2022-01-30.16-43-59.mp4For test, I used this. Better colors should be chosen later, though. QToolButton:hover:checked {
border-top: 1px solid #343840;
border-bottom: 1px solid #4a515e;
border-radius: 2px;
background: qlineargradient(spread:reflect, x1:0, y1:0, x2:0, y2:1, stop:0 #292d33, stop:1 #22262c)
} |
just happened to come across this. this is a nice to have feature and phys' implementation looks good. one suggestion - the hover mode could get a lighter color (but not too light to hide the actual icon). |
Is this as simple as adding the above CSS code in to style.css ? |
It's a little more than that, but not much. It would need to be added to |
I have opened #7202 which implements the hover effect, but I haven't decided on the colour scheme yet. Reviews appreciated. |
Fixed in #7202 |
Can we have glowing buttons, like in FL studio. Like when we press a button, it should light up with a different colour.
Thank you!
The text was updated successfully, but these errors were encountered: