-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More texts for "What is this" #896
Comments
This isn't really a new feature, it's just missing text in some instances.
That part is up to the translators. The message string is included in a tr( "..." ), and this will tell, whatever routine is doing the job..., to include the string for translation. I think it's enough to recompile the project to make the new strings ready for translation.
I think the plan could be that you just start and if someone wants to join in they bump this issue. |
I can add some whatsthis texts for the instruments I've written (parts |
What's this strings for Monstro are done. Whew! That was a lot of writing... |
All wit's for "Song-editor" controllers and logic-pane-points -done (no commits or requests for having anything pulled, being teeth, wheelcarts, birds, or w.e. -cause i have no idea how to -yet ..looks for it in wiki :p |
On 06/27/2014 03:09 AM, musikBear wrote:
Where? |
@musikBear You haven't forked lmms via githubs built-in functions. |
ehh.. im was at home .. at my desk ..is that ..important ? |
Just fork via the website and then git clone from your own fork. If you're using the GitHub GUI on Windows or Mac it's a bit easier too and then you can do your commits directly via the client which is a nice visual although the Be mindful of the branch you are on. I use: git clone -b stable-1.1 http://github.com/tresf/lmms.git ... where Since I don't know the scope of your code changes, I don't know which branch your changes are best suited for but this should at least get you started. |
I believe github have their own client applications for both windows and On Fri, Jun 27, 2014 at 11:19 PM, Tres Finocchiaro <notifications@github.com
Jonathan Aquilina |
@musikBear, here are your changes: #1015. Thanks!! There were some issues with spacing, etc (not leaving a space after the end of a sentence) that needed to be corrected prior to committing. If you plan to offer more contributions like this, I would highly recommend getting Ubuntu/VirtualBox set up so you can edit and preview these changes yourself prior to sending them to the project as it would reduce the burden of someone else performing sanitation. As far as the git commits, the command line stuff is pretty quick to learn and I can help you with that. |
I have 10 pages. All major components is covered. |
"What is this" additions by @musikBear #896
Revert ""What is this" additions by @musikBear #896"
Revert "Revert ""What is this" additions by @musikBear #896""
Old topic, but i have a new angle
Adversaries
Opinions? |
How about keeping the offline text, and adding a link underneath w/ "read
more online". Alternatively "What's This?" and "What's This (Online)" as
separate right click options.
…On Jan 14, 2017 13:52, "musikBear" ***@***.***> wrote:
Old topic, but i have a new angle
In main-menu Under
Help | Online Help
LMMS links to the wiki.
My thoughts were that *what-is-this* could be constructed with this type
of links.
Eg, instead of the integrated popups lmms has now, *what-is-this* would
link to the relevant page in wiki
The benefits
- The codebase would be without hard-coded info
- Changes would only have to be made once (eg in wiki, not in wiki and
codebase)
- Changes would be easy to make, and not include coders
Adversaries
- Users not online cant use it
Opinions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIgVmiW6_nTBnWBE5bd5A1MQyRVidHctks5rSMUhgaJpZM4CH2DU>
.
|
@Spekular but that would still mean 2 different edits if/ when something is being changed, the whole idea is to avoid having double information. If it is split in two parts, one offline, and one online, i cant see any benefits :) |
@musikBear sure, but online-only is no good either. Besides, the information on the wiki should probably be more in depth than what fits in a tooltip. I suppose my idea would just be a convenient way to access the right wiki page. |
That is the adversary i know that, but now-a-days... oh well just a thought.. I will leave this for others to respond |
I believe i have the solution, that would allow users to use wit's offline and still keep the wit's out of the codebase, and make editing very easy: |
Closed via #4128. |
The fine new feature "What is this" has a lot of items that need to written. I will do my part, if wanted. We just need to get a plan for doing them, so none is done 'trice'ish'
Just let me know.
an also, -Translations .. woo - How many languages?
ooooooooooooo
Oki taking some control now
I will devide the objects that need WITs added in 3 categories
Look in thread if some has 'taken' an object and are working on it. I will update the categories as WITs are made, and add 'done' WITs in order. starting here:
WITs ALREADY done:
General Instrument This is identical on all non-vst presets, and should have own datastructure or class -whatever fits architechture best..
Tab ENV/LFO
Specified Instruments (of cause only the PLUGIN tabs need to have specified wit's!)
Monstro
Panels
Automation-editor
BB-editor
FX-rack
General instrument button
LFO-controller
LFO-rack
Main-screen
Piano-roll
Song-editor
Effects
The text was updated successfully, but these errors were encountered: