Proposed fix for 1352 Mk2, move the loaded instrument to the parent thre... #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for following up with this. Merging, since you were the author of #1519. |
tresf
added a commit
that referenced
this pull request
Jan 10, 2015
Proposed fix for 1352 Mk2, move the loaded instrument to the parent thre...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1352 Mk2, move the loaded instrument to the parent thread.
address the issue in #1550.
This moves the loaded instrument back to the parent thread, for thread affinity.
I did try another totally different implementation, using signals, and slot and QueuedConnecton, to process the loading in the event loop, as opposed to immediately, but this still caused the same deadlock.
The issue with my previous pull request #1519, was the the instrument was loaded on a separate thread, and needed to be on the same thread as the parent TrackContainer to be able to use the Qt event loop