Prevent running as root user #1784
Conversation
|
Test results:
|
| @@ -137,6 +142,14 @@ int main( int argc, char * * argv ) | |||
| } | |||
| } | |||
|
|
|||
| #ifndef LMMS_WIN32 | |||
There was a problem hiding this comment.
Whoops... typo here... should be LMMS_BUILD_WIN32. Travis is pissed off at me now.
There was a problem hiding this comment.
Travis is pissed off at me now.
Im close to turning it off on my repo, that or pay for the osx builds, my inbox is full of travis fail emails.
There was a problem hiding this comment.
Yeah, @lukas-w should probably look into why it is failing... Looks like Homebrew is breaking on a package dependency. I can see why it would be particularly annoying for those that have many open pull requests.... :)
There was a problem hiding this comment.
Its not a new thing, ever since lmms had travis build osx, my local repo fails every time, hence considering paying for osx on my reapo if it's cheep enough, according to my inbox, travis failed is my new best friend :) lol
There was a problem hiding this comment.
Oh... I see what you are saying... I wonder if there's a way to edit the YML to only run the script for LMMS/lmms so that the PRs can be flagged as pass/fail without bugging out the forks.
tresf
force-pushed
the
master
branch
4 times, most recently
from
d4d80cd to
02bb058
Compare
|
Added warning message on win32 so it doesn't complain about unused variable.... 😆 |
| else if( argc > i && QString( argv[i] ) == "--allowroot" ) | ||
| { | ||
| // Ignore, processed earlier | ||
| #ifndef LMMS_BUILD_WIN32 |
There was a problem hiding this comment.
DOH! #ifdef, not #ifndef :)
|
Fixed the win32 used variable problem by adding a warning to win32 when the Travis looks good. Merging. Please blame me if problems arise from this, but I think it is good. |
Closes #1770