Update effect plugin icons #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. Maybe fix the apply/cancel icons too? |
|
Maybe after #2908 is merged, since that adds the new icons. |
|
I'm not sure I agree with the gear although I do prefer it to the penguin. I doubt this PR is intended for ideas, but some food for thought, also @RebeccaDeField
Edit: Just noticed this PR is only for the built-in (native) effects. |
Nope, I also replaced the icon for VST and LADSPA's. I like your ideas, gonna design something up. |
|
Does this look better? |
I like those a lot. |
Umcaruje
changed the title
|
That's really great, @Umcaruje! |
|
Glad you like 'em 😄 |
|
But we have to check this with the classic theme, too. |
|
|
I really like this 👍 |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Replace the generic effect icon with a more streamlined one * Add seperate icons for different plugin types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2388
The icon is based on @RebeccaDeField's cogwheel design for the settings icon.
I think icon would fit a lot better with the new theme.