-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTML markup for knob labels #3134
Conversation
This is another example of why #3071 should be solved. Most of this patch is about format changes. Regarding the main purpose, what kind of HTML effects do you plan to use that cannot be done through the style sheet? Is this feature for knob labels only or will this be extended to all labels? |
Right... That's because I have integrated a code formatter in
Well, that's relating to some chatter in our chat room: multi-line labels are not supported in knob labels, either |
5be62ff
to
bd6bc89
Compare
Have you tried using QLabel? |
QLabel works though. |
Bumping. ^ |
I reverted some formatting changes and resolved conflicts. There are some things to change more, e.g., fix a memory from |
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12201-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfb-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12201?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12204-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12204?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12202-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12202?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/cioion0x98emrqgh/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37389943"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/tl0c8a9f4tb3npef/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37389943"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12205-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12205?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ca00ec812758f77e01dcad891d1928733c7980b6"} |
It's now ready to review/merge. |
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com> Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com> Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com> Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Add HTML rich text support for knob label
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)