Flanger LFO rate syncronised #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the chosen values the tempo sync menu now leaves out the longest time signatures, whole note and eight beats. I think long sweep times is especially useful for flangers. Here is what it looked like before.
|
|
Good catch, I will revise |
|
I have updated the PR, to restore the syncing of 8 beats notes, |
Works. The 5 second maximum period is in my opinion much to small. I want to be able to sweep the flanger over a long timer, a minute or so. Like a real hippie. |
The LFO rate was not correctly syncronising to tempo This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period, instead of a frequency. The knob now reports the correct values in the GUI. Flanger LFO maximum period incressed to 60 seconds
|
I have adjusted the maximum period to be 60 seconds, This does sound nice now, |
zonkmachine
approved these changes
May 5, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
The LFO rate was not correctly syncronising to tempo This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period, instead of a frequency. The knob now reports the correct values in the GUI. Flanger LFO maximum period incressed to 60 seconds
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
The LFO rate was not correctly syncronising to tempo This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period, instead of a frequency. The knob now reports the correct values in the GUI. Flanger LFO maximum period incressed to 60 seconds
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
The LFO rate was not correctly syncronising to tempo This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period, instead of a frequency. The knob now reports the correct values in the GUI. Flanger LFO maximum period incressed to 60 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LFO rate was not correctly synchronizing to tempo
This has been rectified, to utilize the TempoSyncKnob as intended, returning a period,
instead of a frequency. The knob now reports the correct values in the GUI.
fixes #3335