Paint a black rectangle under patterns to prevent glitches #3759
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the point of having transparent colors if you paint the background? |
|
@gi0e5b06 there's absolutely no point to them now, but if someone does this in a custom theme they won't see it as an issue |
michaelgregorius
approved these changes
Aug 9, 2017
There was a problem hiding this comment.
@Umcaruje I have built it from your repository and it looks good to me!
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3709
As suggested by @michaelgregorius I added a black rectangle to act as a background for the patterns. No more glitches. Here are transparent patterns with some random-ass colors:
