Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EQ: fixes bug when changing value by double click on fader/knob #4018

Merged
merged 1 commit into from
Nov 30, 2017
Merged

EQ: fixes bug when changing value by double click on fader/knob #4018

merged 1 commit into from
Nov 30, 2017

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Nov 28, 2017

fixes #4011

@BaraMGB BaraMGB requested a review from husamalhomsi November 28, 2017 22:39
husamalhomsi
husamalhomsi approved these changes Nov 29, 2017
View reviewed changes
Copy link
Member

@husamalhomsi husamalhomsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Fixes the issue with no side effects. 👍

@BaraMGB BaraMGB merged commit 898e799 into LMMS:stable-1.2 Nov 30, 2017
@BaraMGB BaraMGB deleted the eqbug branch November 30, 2017 15:57
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@BaraMGB
fixes bug when changing value by double click on fader/knob (LMMS#4018)
3c4a065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@husamalhomsi husamalhomsi husamalhomsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EQ handles aren't updated when entering values after dragging them.
2 participants
@BaraMGB @husamalhomsi