Fix occasional audio interface deadlock #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review please! I want to merge this soon, but I think it'd be better to wait for reviews. |
|
Merging since there was no review and I can find any regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4406 by ensuring audio thread has read the
NULLbuffer before stop processing. Dropping them have caused several regressions(#4406, #3397, #3396, etc.) becausestopProcessingof backend can be called before it receivesNULLbuffer.Instead of relying on per-backend semaphores(Dropped for SDL in 98346f7, for JACK in 1dcacbb),
Mixer::fifoWriternow checks it.