-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI 60 times per second. #4570
Conversation
Merge? |
I remember doing this on my own fork, and I noticed that the EQ visualizer seemed to behave somewhat differently. Has anybody else noticed this? I didn't see it as a problem, but I might have missed something. |
I think the falloff in |
Also in |
I will look into it in the weekend. |
Adjusted also falloff of mixer faders ( |
I can't think of any other possible issues with this. The fact that it's not actually 60 fps still feels wrong to me (62.5 fps, assuming the timer is accurate), but I doubt this will cause any actual issues. Merge? |
I'm not sure if this one is okay for |
I would hate to defer something so simple and beneficial to 1.3, but we are on feature freeze. It's your call, @PhysSong, I won't complain if we have to defer. |
It's more like a fine-tuning than feature. |
Merging into |
Any win Test binaries? |
@musikBear This will be part of RC7. So please wait a few days. :) |
@PhysSong Just want to let you know, that RC7 runs fine on my old Tube-monitor 👍 |
Should lmms/src/gui/TimeLineWidget.cpp Line 96 in d8fb07f
|
@DomClark Nice catch! |
* Update UI 60 times per second * Adjust falloff values
In addition to LMMS#4570.
Fixes #4562.